Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

footer added #2 #3

Merged
merged 2 commits into from Apr 5, 2019

Conversation

@aqeelparpia
Copy link

commented Mar 6, 2019

Footer fixed. Please let me know if that's how you wanted it to be looking. Thanks @bsoyka

@aqeelparpia aqeelparpia referenced this pull request Mar 6, 2019
0 of 4 tasks complete

@bsoyka bsoyka self-requested a review Mar 7, 2019

@bsoyka bsoyka added the enhancement label Mar 7, 2019

@bsoyka
Copy link
Member

left a comment

I have added comments on lines 34 and 89. So far, it looks pretty good. Thank you for doing this, @aqeelparpia.

index.html Outdated
padding: 5px;
margin: 0px auto;
text-align: right;
font: 25px Georgia, "Times New Roman", Times, serif;

This comment has been minimized.

Copy link
@bsoyka

bsoyka Mar 7, 2019

Member

Lines 34 and 35 can be removed, as the font is already set by Bootstrap.

index.html Outdated
<div class="content">
<img src="logo.png" >
<div class="foot">
<p><a href="https://github.com/mystery-egg/mystery-egg.github.io" target="_blank">Github Repository</a></p>

This comment has been minimized.

Copy link
@bsoyka

bsoyka Mar 7, 2019

Member

Could you fix the capitalization of "GitHub", please? (Line 89)

@bsoyka bsoyka self-requested a review Mar 7, 2019

@bsoyka

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

@aqeelparpia Please respond or make the requested changes or I will close this PR to give someone else a chance to help out.

@bsoyka
bsoyka approved these changes Apr 5, 2019
@bsoyka

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

Closes #2

@bsoyka bsoyka merged commit 615d4d4 into mystery-egg:master Apr 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.