footer added #2 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsoyka
requested changes
Mar 7, 2019
There was a problem hiding this comment.
I have added comments on lines 34 and 89. So far, it looks pretty good. Thank you for doing this, @aqeelparpia.
index.html
Outdated
| padding: 5px; | ||
| margin: 0px auto; | ||
| text-align: right; | ||
| font: 25px Georgia, "Times New Roman", Times, serif; |
There was a problem hiding this comment.
Lines 34 and 35 can be removed, as the font is already set by Bootstrap.
index.html
Outdated
| <div class="content"> | ||
| <img src="logo.png" > | ||
| <div class="foot"> | ||
| <p><a href="https://github.com/mystery-egg/mystery-egg.github.io" target="_blank">Github Repository</a></p> |
There was a problem hiding this comment.
Could you fix the capitalization of "GitHub", please? (Line 89)
|
@aqeelparpia Please respond or make the requested changes or I will close this PR to give someone else a chance to help out. |
bsoyka
approved these changes
Apr 5, 2019
|
Closes #2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Footer fixed. Please let me know if that's how you wanted it to be looking. Thanks @bsoyka