Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distributing a self-contained script #5

Closed
marijnh opened this issue Nov 27, 2019 · 4 comments
Closed

Distributing a self-contained script #5

marijnh opened this issue Nov 27, 2019 · 4 comments

Comments

@marijnh
Copy link

marijnh commented Nov 27, 2019

Firstly, thanks for doing this. Before I found it, running ESLint in the browser seemed impossible. With this, it only seems painful.

After several hours of messing around with Rollup and Babel, I managed to create an ESLint file that I can load in IE11. It's a 1.3mb monster that I'd rather not check into version control, but I'm also loath to include this entire build process with all the plugins that it requires in my package's build process. So I'm leaning towards stuffing it into a separate npm package. But that package already sort of exists here, and it seems you even have a way to keep it up to date.

Would you consider including a full, self-contained built artifact in this package? Or adjust your scripts to publish a second package with such a file?

@marijnh
Copy link
Author

marijnh commented Nov 28, 2019

Ah, never mind this—there'd be no single right way to do it, since you'd be bundling up all kinds of polyfills due to the way the codebase is using modern JS all over. I'll just set up a crude thing myself and handle the updates manually.

@marijnh marijnh closed this as completed Nov 28, 2019
@mercmobily
Copy link

This is weird... @marijnh, I keep on virtually bumping into you! I was about to write to you about precisely this issue... Is there a plan for CodeMirror 6 to use EsLint? Seeing your ticket here, I assume that's the way you are going... is that right?

@marijnh
Copy link
Author

marijnh commented Feb 13, 2021

See the esLint export in @codemirror/lang-javascript.

@shipagency
Copy link

Oh c'mon, no way!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants