Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel tasks can't be killed in Webstorm Terminal on Windows #33

Open
coryhouse opened this issue Mar 24, 2016 · 14 comments
Open

Parallel tasks can't be killed in Webstorm Terminal on Windows #33

coryhouse opened this issue Mar 24, 2016 · 14 comments

Comments

@coryhouse
Copy link

This is admittedly Webstorm specific, but as FYI:

This is the same issue that I reported in Issue 32, but it occurs in Webstorm's terminal on Windows. Hitting Ctrl+C produces the prompt for "Terminate batch job (Y/N)?", but answering "Y" doesn't actually get you back a usable command line. It appears to be using the native Window command line behind the scenes since this is shown when I open the Webstorm terminal:

Microsoft Windows [Version 6.1.7601]
Copyright (c) 2009 Microsoft Corporation. All rights reserved.

The result of hitting Ctrl+C:
^C^C^CTerminate batch job (Y/N)? Terminate batch job (Y/N)? ^CTerminate batch job (Y/N)? ^^CCTerminate batch job (Y/N)? Terminate batch job (Y/N)? Terminate batch job (Y/N)? ^CTerminate
batch job (Y/N)? Terminate batch job (Y/N)? Y

It becomes frozen after answering Y.

@mysticatea
Copy link
Owner

Thank you for this issue.

Mmm, I don't have WebStorm...

@coryhouse
Copy link
Author

There's a free trial at the link I provided in the issue. 👍

@mysticatea
Copy link
Owner

Sorry, I had used the trial version before, so I cannot use it now.

@dasa
Copy link

dasa commented Jun 10, 2016

A free open source license is available. Details at:
https://www.jetbrains.com/buy/opensource/?product=webstorm

@mysticatea
Copy link
Owner

Oh, thank you for the information!

@mysticatea
Copy link
Owner

mysticatea commented Jun 14, 2016

Thank you.
I got the WebStorm Free Open Source License for npm-run-all.

  1. I tried the npm start of react-slingshot in WebStorm's terminal.
    Fortunately (or unfortunately), it worked fine.
    ws-terminal
  2. I checked out a commit of March. But it failed to compile some native modules... 😢

@coryhouse Could you reproduce this issue currently?

@coryhouse
Copy link
Author

It's still occurring for me on Windows 7. What version of Windows are you on?

@mysticatea
Copy link
Owner

mysticatea commented Jun 16, 2016

I'm using:

  • Windows 7 (Japanese)
  • WebStorm 2016.1.3
  • Node 6.2.0
  • npm 3.9.0

@coryhouse
Copy link
Author

Odd, I'm running the exact same setup. I'm stumped why we're seeing different results.

@mysticatea
Copy link
Owner

Weird 😓.
I will continue to investigate...

@zont
Copy link

zont commented Jan 17, 2017

The same behavior with FAR Manager and Windows 10:

  1. npm-run-all -l -p dev:*
  2. CTRL+C and say Y
    Result: task was killed...
  3. F10 to exit FAR Manager
    Result: failed, FAR not closed...

Broken FAR process:
image

Normal FAR process:
image

@zont
Copy link

zont commented Feb 17, 2017

The same behavior with cmd and Windows 10:

  • npm-run-all -l -p dev:*
  • CTRL+C and say Y

Result: task was killed...

  • type exit to close cmd window

Result: failed, window not closed...

@zhekaus
Copy link

zhekaus commented Dec 8, 2017

I have quite similar issue.
I use npm-run-all to run Angular (ng serve), Laravel (php artisan server) and pug-cli simultaneously like this (a package.json fragment):

"scripts": {
…
    "serve": "ng serve --proxy-config proxy.conf.json",
    "sleep": "sleep 3",
    "serve:postponed": "run-s -s sleep serve",
    "start": "run-p pugw laravel serve:postponed",
    "laravel": "php ../lar/artisan serve",
    "pug": "pug src",
    "pugw": "pug src -P -w"
  },

If I hit Ctrl+Cas many times I want – nothing happens.
If I hitCtrl+C and Enter, I finally can see the bash prompt. However, all stuff (php.exe and ng, pug, etc.) continue work in background, and bash freezes

PS. Win 10

@SargoDarya
Copy link

We have the same issue on MacOS. Even though we're pressing Ctrl+C like mad, the processes continue to run. Restarting will pile up more and more of those processes bringing everything slowly to a halt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants