Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm-run-all doesn't work with pnpm #67

Closed
zkochan opened this issue Oct 26, 2016 · 4 comments
Closed

npm-run-all doesn't work with pnpm #67

zkochan opened this issue Oct 26, 2016 · 4 comments
Labels

Comments

@zkochan
Copy link

zkochan commented Oct 26, 2016

We started to use npm-run-all at pnpm and we noticed that it doesn't work when installed with pnpm. The reason is that we create a proxy bin file (this is needed to allow running deps with the --preserve-symlinks option). As a result this check in npm-run-all fails. What is the reason for that check? Can it be removed?

I filed a defect on pnpm to fix this issue pnpm/pnpm#413. However, currently I don't know how this can be fixed on pnpm side. Could this be fixed on npm-run-all side?

@mysticatea
Copy link
Owner

Thank you for this issue.

The check is used for tests.
It's the official way to distinguish the entry file: https://nodejs.org/api/modules.html#modules_accessing_the_main_module

@mysticatea
Copy link
Owner

That check was needed in order to measure coverage.
I'm using nyc now, so I might be possible to remove the check.

@zkochan
Copy link
Author

zkochan commented Nov 3, 2016

That would be awesome! Thank you!

@iamstarkov
Copy link

yay 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants