Skip to content
This repository has been archived by the owner on Jul 24, 2019. It is now read-only.

Use unique name instead of object itself when comparing between metadata elements. #46

Closed
mysticfall opened this issue Feb 27, 2013 · 1 comment
Assignees
Labels
Milestone

Comments

@mysticfall
Copy link
Owner

Found a very subtle problem with Mondrian's DelegatingRole, that when it wraps RolapMember instance into RolapHierarchy$LimitedRollupMember, they no longer return true when equals() method is invoked with the other as an argument, which could make various parts of Pivot4J not functioning properly.

So, it would be safe to compare between unique name properties of members instead of the member objects themselves to prevent such a problem.

@ghost ghost assigned mysticfall Feb 27, 2013
@mysticfall
Copy link
Owner Author

I'll change the relevant code to be as defensive as possible. Though it's not viable to change all the cases like checking for .contains() on List of members without making codebase a mess, so the full resolution would be possible when below issue is addressed from Mondrian project:

http://jira.pentaho.com/browse/MONDRIAN-781?focusedCommentId=138035#comment-138035

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant