Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Book of Life at 21:27 #16

Open
ninapaley opened this issue Feb 27, 2022 · 2 comments
Open

Book of Life at 21:27 #16

ninapaley opened this issue Feb 27, 2022 · 2 comments

Comments

@ninapaley
Copy link

Thanks to my unhygienic file numbering, 21:27 in the app shows book_of_life2.mov , whereas it should show book_of_life.mov . Again, the number extensions in the filenames should only be ignored if the number immediately follows an underscore ( _ ). Apologies for naming and numbering my files so terribly!

However I kinda like this mix-up, book_of_life2.mov works at least as well as book_of_life.mov , even though it's a repeat. What do you think, aesthetically?

@toolness
Copy link
Contributor

Ah yeah sorry, from looking at the filenames it seemed quite challenging to figure out the right algorithm (some files had very funky different names) so I just used the Levenschtein distance algorithm instead of hand-coding anything... it seems to have worked in the vast majority of cases though!

One unfortunate thing is that even if we repeat, because of the way things work, we'll actually be putting two copies of the exact same movie in the install, and the engineer in me chafes at the waste of space! lol. I guess it would be easiest and most preferable for me to use the movie you intended, to maintain as much parity with the website as possible, but it's up to you!

@ninapaley
Copy link
Author

OK let's keep the files I intended!

(I can't believe repeats require duplicates in the app! Crazy. I chafe at the waste too!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants