Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update required for mythweb_id cookie (SameSite attribute) #72

Closed
mkbloke opened this issue Feb 25, 2022 · 0 comments · Fixed by #73
Closed

Update required for mythweb_id cookie (SameSite attribute) #72

mkbloke opened this issue Feb 25, 2022 · 0 comments · Fixed by #73

Comments

@mkbloke
Copy link
Contributor

mkbloke commented Feb 25, 2022

Changes are coming in browsers relating to cookies that either do not specify SameSite or set SameSite=None on cookies.

Firefox can now show:

Cookie “mythweb_id” will be soon rejected because it has the “SameSite” attribute set to “None” or an invalid value, without the “secure” attribute. To know more about the “SameSite“ attribute, read https://developer.mozilla.org/docs/Web/HTTP/Headers/Set-Cookie/SameSite

in the console.

For further information, you can also refer to:

https://hacks.mozilla.org/2020/08/changes-to-samesite-cookie-behavior/
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie/SameSite#fixing_common_warnings

One option is to specify the Secure attribute with the cookie when SameSite=None, the others are to specify either SameSite=Lax or SameSite=Strict. The former will only work for HTTPS connections, while the latter two will work for both HTTP and HTTPS connections. Given that I believe there is no requirement for a setting of either None or Lax, it seems easiest to implement Strict, which should allow folks to use either HTTP or HTTPS on their servers without problems and without additional code to determine which is in use (as would apply if SameSite=None and the Secure attribute were used).

I will submit a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant