Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature : Tour Pauses] Add the ability to delete tour pauses #1110

Closed
FJBDev opened this issue May 20, 2023 · 5 comments
Closed

[Feature : Tour Pauses] Add the ability to delete tour pauses #1110

FJBDev opened this issue May 20, 2023 · 5 comments
Assignees
Milestone

Comments

@FJBDev
Copy link
Collaborator

FJBDev commented May 20, 2023

What is missing ?

Add the ability to delete tour pauses from the Tour Book View and the Tour Pauses View

@wolfgang-ch
Copy link
Collaborator

When I delete all pauses in the pauses view, then the pauses are still available in the tour data series. So I don't understand why only one part of the pauses are deleted.

image

@FJBDev
Copy link
Collaborator Author

FJBDev commented Aug 4, 2023

The column you show in your image is a "Break", which is very different than a pause. Deleting a pause won't delete a "Break" as those are computed with an algorithm.
Did you make sure that the pause is not present anymore ?

image

@wolfgang-ch
Copy link
Collaborator

Did you make sure that the pause is not present anymore ?

Pauses are gone in the time slice editor

The column you show in your image is a "Break", which is very different than a pause. Deleting a pause won't delete a "Break" as those are computed with an algorithm.

I was a bit confused but you are correct, pause != break

@wolfgang-ch
Copy link
Collaborator

When I delete the 3./4. pause, then the 1./2. is removed

image

image

@FJBDev
Copy link
Collaborator Author

FJBDev commented Aug 4, 2023

Good catch. I also found a bug when I tested myself this morning.

They should all be fixed in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants