Use PR reviews as the voting mechanism

[myyk]

Good idea from @dominikwilkowski that I'd like to add in here to replace the complicated comment modifications: #763 (comment)

When I started this project, I didn't consider that I actually have both 👍🏽 and 👎🏽 in a review, so no need to add another vote tallying comment to get the votes from. I think the vote summary is still useful, so I will keep that.

This does require all voters to be PR reviewers for the plugin to work. That seems acceptable for a git-democracy using project though.

[myyk]

Oh hrm... but that would mean that there is still an admin class of users needed to add in the user which is something that I'd want to avoid.

[myyk]

It might work if there's a way to setup an org with default of everyone as able to PR.

[dominikwilkowski]

I think you would want an admin to approve the changes to the voting structure. As a sec feature really. Because if you don't have that the system can be exploited. Fundamental changes like voting structures should be on a higher level than the votes on PR that touch code no?

[myyk]

I always wanted to voting on the voting structure to be part of the project itself. It does suck that living within Github, we need admins still and I don't see a way around that while also being a Github Action.

I think if voting to change the voting structure needs more votes than for other files, then it would be nice if it could be configured with multiple configurations.

Also I think there's still flexibility for the admin add/remove voters and also circumvent rules if necessary to fix things if that's what a project wants.

[myyk]

Closing as fixed. Happy to further discuss the idea of the voting structure being governed outside of git-democracy.as a new issue.