Improve XDomainRequest implementation #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removes ActiveXObject support, and improves detection of XDomainRequest.
This would help testing browser support.
|
Viewing with https://github.com/mzabriskie/axios/pull/185/files?w=1, makes line 40-60 less scary |
| request = null; | ||
| request.onload = function handleLoad() { | ||
| if (!request) { | ||
| return; |
There was a problem hiding this comment.
I don't know why this check was in the handleReadyState method. The request always contains the instance filled at this point.
|
@jtangelder thanks for the PR. I'm swamped this week with a project at work, but I will take a look at this as soon as I get a chance. |
mzabriskie
added a commit
that referenced
this pull request
Jan 17, 2016
Improve XDomainRequest implementation
|
Thanks for the PR, this makes the code a lot cleaner! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw the XDomainRequest detection and forsaw an issue with its implementation. The
ieVersion()method would break the webworker support, since it adds a dependency to thedocument. My solution checks for the propertywithCredentials, since it was introduced at IE10.Also removed
ActiveXObjectsupport since that is only for IE7 and older, and Axios doesn't support these, right?And added some manual tests to verify the working in browsers. Tested with these on Saucelabs and my local machine in Win7-IE9, Win7-IE10, Win7-IE11 and Chrome 47.