Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to specify generated class visibility #70

Closed
mariotaku opened this issue Sep 11, 2016 · 6 comments
Closed

Option to specify generated class visibility #70

mariotaku opened this issue Sep 11, 2016 · 6 comments

Comments

@mariotaku
Copy link

Thanks for this awesome implementation!

It would be nice if visibility can be changed (to default or internal).

@mzaks
Copy link
Owner

mzaks commented Sep 15, 2016

Do you mean for generated classes or for the infrastructure?

@mariotaku
Copy link
Author

@mzaks Generated classes

@mzaks
Copy link
Owner

mzaks commented Sep 15, 2016

Could you please elaborate on that. I just want to understand the use case better.
FlatBuffers support namesapcing which I didn't supported yet because there is no namespace concept in Swift. But it would be possible to namespace by nesting classes inside empty enums. At some point I wanted to drop the idea but now I am reevaluating it. specifically if you have multiple fbs file wich would like to reuse tables.

@mariotaku
Copy link
Author

Current implementation only generate public classes, when using in App development, all extensions will have to made more public, when developing frameworks, we may want to hide some classes instead of making them public.

@mzaks
Copy link
Owner

mzaks commented Sep 15, 2016

You mean if you want to build a Framework which make use of the generated classes and you would not want to expose those classes to the end user (application developer)
OK this is a valid point. I could introduce a custom attribute. It would be specific for FlatBuffersSwift code generator because the main flatc code generator doe s not support such feature out of the box afaik.

@mzaks
Copy link
Owner

mzaks commented Mar 4, 2019

I created a separate issue in code generation project and I am closing this one.
mzaks/FlatBuffersSwiftCodeGen#7

@mzaks mzaks closed this as completed Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants