Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Change Event from Start Date to End Date #39

Closed
jianyu-li opened this issue Nov 13, 2020 · 7 comments
Closed

[Request] Change Event from Start Date to End Date #39

jianyu-li opened this issue Nov 13, 2020 · 7 comments

Comments

@jianyu-li
Copy link

jianyu-li commented Nov 13, 2020

Hi @mzeryck

Would it be possible to change line 748 in the Weather Cal code.js file to

return (event.EndDate.getTime() > currentDate.getTime()) ? Or at least make it an option?

This would mean the event would still show even if it has already started (sometimes I'm late!). Then it goes away once the event is over.

Thanks for your consideration!

@jianyu-li jianyu-li changed the title [Request] [Request] Change Event from Start Date to End Date Nov 13, 2020
@mzeryck
Copy link
Owner

mzeryck commented Nov 14, 2020

Ah, I think this is a good idea! I think I will work on adding the ability to adjust this amount - for example, waiting 5 min versus 15 min.

@jianyu-li
Copy link
Author

Cool!

@HelloSmithers
Copy link

HelloSmithers commented Nov 15, 2020

Could reminders also be shown in the reverse order of what is in the picture attached (on the right hand side)?
unnamed

@mzeryck
Copy link
Owner

mzeryck commented Nov 16, 2020

@jianyu-li The newest version of the code has this feature! If you want to update without changing your other widget settings, you can run the "Update code" function, and then add this setting to the EVENTS section:

// Minutes after an event begins that it should still be shown. 
,minutesAfter: 5

Please let me know if that works OK!

@jianyu-li
Copy link
Author

You are on a roll tonight! Thanks!

@mzeryck
Copy link
Owner

mzeryck commented Nov 16, 2020

This is what weekend procrastination looks like 😅 and no problem!

@mzeryck mzeryck closed this as completed Nov 16, 2020
@jianyu-li
Copy link
Author

Also thanks for telling me what line to add so I didn’t have to update my whole thing! Very helpful when you have it fine tuned just right :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants