Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with offline-plugin #70

Closed
ctrlplusb opened this issue Dec 8, 2016 · 4 comments
Closed

Incompatible with offline-plugin #70

ctrlplusb opened this issue Dec 8, 2016 · 4 comments
Labels

Comments

@ctrlplusb
Copy link

ctrlplusb commented Dec 8, 2016

See ctrlplusb/code-split-component#20

It builds the first time okay, but on second build after cache exists the following error is thrown:

Error: offline-plugin: Plugin's runtime wasn't added to one of your bundle entries. See this https://goo.gl/YwewYp for details.
at Compiler. (/Users/foo/bar/baz/node_modules/offline-plugin/lib/index.js:279:20)

@ctrlplusb
Copy link
Author

ctrlplusb commented Dec 8, 2016

This could be an issue with offline-plugin though.

@mzgoddard
Copy link
Owner

Thanks @ctrlplusb, this looks like an issue with offline-plugin using a hook in webpack to conveniently track if the the offline runtime is installed. HardSource wants to skip that step since the module is already built.

This will either be fixed by offline-plugin tracking that the offline runtime is installed through a different webpack hook or through me finishing the hard source plugin interface and offline plugin detecting and plugging into hard-source to solve this.

@ctrlplusb
Copy link
Author

Thanks for looking into this @mzgoddard - and for helping me update my webpack plugin to work with yours. You are a model citizen of the OSS community. ❤️

@mzgoddard
Copy link
Owner

Fixed as of offline-plugin@4.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants