Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to use gerrit-checklist in gerrit 2.11 #5

Closed
wklxd opened this issue Jan 6, 2016 · 2 comments
Closed

how to use gerrit-checklist in gerrit 2.11 #5

wklxd opened this issue Jan 6, 2016 · 2 comments

Comments

@wklxd
Copy link

wklxd commented Jan 6, 2016

hello:
when i install gerrit-checklist in gerrit 2.11, i got this error

    ReferenceError: $ is not defined
        var gerTextArea = $('.popupContent .gwt-TextArea');

so i guess gerrit-checklist use jquery。
but i don't know how to install jquery in gerrit, so can you tell me?

many thanks

@mziwisky
Copy link
Owner

mziwisky commented Jan 9, 2016

hi, when you say you're "installing" it in gerrit, what exactly do you mean? I wrote this just as a user script, to be included in the page via a tool like TamperMonkey. i don't know anything about gerrit administration, but if you're trying to import it as a gerrit plugin or something like that, it probably won't work.

that said, if you're just trying to use it as a userscript and you're getting that error, then the quick and dirty solution would be to just copy and paste the jquery source before this script. or if you're looking for something more elegant/clever/tricky, you could load jquery dynamically as described here: http://stackoverflow.com/a/950146/2093416

@wklxd
Copy link
Author

wklxd commented Jan 10, 2016

yeah, i got that error when i try to use it as a gerrit plugin。

so, i think i need to try TamperMonkey

many thanks

@mziwisky mziwisky closed this as completed May 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants