Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peer dependencies error after published 1.4.3 version #105

Closed
r4costa opened this issue Nov 14, 2021 · 1 comment
Closed

peer dependencies error after published 1.4.3 version #105

r4costa opened this issue Nov 14, 2021 · 1 comment

Comments

@r4costa
Copy link

r4costa commented Nov 14, 2021

Hi,

In my project with Angular 8 (sorry about that), if you delete node-modules and run "npm install' I got

npm WARN angular-google-tag-manager@1.4.3 requires a peer of @angular/common@^12.0.3 but none is installed. You must install peer dependencies yourself.

Ok, just a WARN.. In my packahe.json I have:

"dependencies": {
...
"angular-google-tag-manager": "^1.4.1",
...
}

After install, doesn't appears "google-tag-manager" folder inside node-modules and when I run my project or execute testes, I got:

Cannot find module 'angular-google-tag-manager' from 'src/app/[project file].ts'

I solved with

"dependencies": {
...
"angular-google-tag-manager": "=1.4.1",
...
}

But I don't know why I got that error. That didn't happen with 1.4.2 version published.

@mzuccaroli
Copy link
Owner

mzuccaroli commented Nov 14, 2021

1.4.3 version is released to add angular 13 support, your angular version is quite old all dependancies are, the best solution is to use an older releaser of the library, i think that version 1.2 or older was officially tested with angular 8
the core lib hasn't changed so you can use older version with your project . If surprisingly v 1.4.1 work with your project you can safely use that otherwise try older versions:
npm install angular-google-tag-manager@1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants