Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Iframe in body tag? #49

Closed
DK9000 opened this issue Jan 4, 2021 · 4 comments
Closed

No Iframe in body tag? #49

DK9000 opened this issue Jan 4, 2021 · 4 comments

Comments

@DK9000
Copy link

DK9000 commented Jan 4, 2021

The iFrame is not popping up in the body tags? Am i doing something wrong? I did follow the article linked in the NPM.

App.module.ts

`@NgModule({
declarations: [AppComponent, ParallaxDirective, DropzoneDirective, DocPipe],
imports: [
HomeModule,
HttpClientModule,
NavsModule,
AppRoutingModule,
DeferLoadModule,
AgmSnazzyInfoWindowModule,
BrowserModule,
ToastrModule.forRoot(),
AngularFireAuthModule,
AngularFireModule.initializeApp(environment.firebase),
AngularFirestoreModule,
AngularFireStorageModule,
BrowserAnimationsModule,
Ng2ImgMaxModule,
ImageCropperModule,

],
providers: [
CaseService,
GeoService,
GeocodeService,
GoogleMapsAPIWrapper,
AuthService,
GoogleAnalyticsServiceService,
FilterService,
{ provide: "googleTagManagerId", useValue: "MY ID!!!" },
],
bootstrap: [AppComponent],
})

app.component.ts `

` ngAfterViewInit() {
this.setVideo();
this.gtmService.addGtmToDom();
}

constructor(
private router: Router,
private gtmService: GoogleTagManagerService
) {

this.router.events.forEach(item => {
  if (item instanceof NavigationEnd) {
    const gtmTag = {
      event: 'page',
      pageName: item.url
    }
    this.gtmService.pushTag(gtmTag)
  }
})

}`

@gabriel-eguia
Copy link

Same problem here, could you solve this?

@mzuccaroli
Copy link
Owner

can you try with the new version?

@DK9000
Copy link
Author

DK9000 commented Feb 7, 2021

Mine works for some reason. Tag manager is up and running on my site, but the iFrame is not set like in the tutorial, but it works :)

@DK9000 DK9000 closed this as completed Feb 7, 2021
@mzuccaroli
Copy link
Owner

dont worry the noscript iframe was removed by this commit a10374c#diff-5dda773090c6f399df6ea76b4d916ddcb78c06c2c035ecd49efe93b4dfed55b5
i need to update the tutorial

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants