Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will you accept the PR if I port it to C++? :) #42

Open
fzyzcjy opened this issue Jul 20, 2020 · 6 comments
Open

Will you accept the PR if I port it to C++? :) #42

fzyzcjy opened this issue Jul 20, 2020 · 6 comments

Comments

@fzyzcjy
Copy link

fzyzcjy commented Jul 20, 2020

Hi I like the idea very much, and I see some people wanting the C++ version. Thus I would like to port it to C++. If I do so will you accept the PR?

@fzyzcjy
Copy link
Author

fzyzcjy commented Jul 28, 2020

Already done a c++ version now.

@sur5r
Copy link

sur5r commented Oct 15, 2020

Does your C++ version result in shorter processing times? Is it available somewhere?

@zvezdochiot
Copy link

Hi @fzyzcjy .

Maybe add new repo: cnoteshrink? So it will be easier to support the mantainers than to mix everything into one mess.

@zvezdochiot
Copy link

@zvezdochiot
Copy link

zvezdochiot commented Dec 23, 2022

Hi @fzyzcjy .

See https://github.com/ImageProcessing-ElectronicPublications/noteshrink-c

v1.1:

  • working version of the utility
  • fix KMeans start value and not BG
  • despeckle 3x3 FG mask
  • added options and help.

PS: ⚠️ issue can be closed.

@fzyzcjy
Copy link
Author

fzyzcjy commented Dec 23, 2022

🎉 Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants