Added Python 3 Compatibility #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! 2 minor changes before accepting PR: I spell it "writeup" in my other 5 repos, so would like to preserve that spelling to maintain consistency across them. Also, printing out the results of the postprocessing command got a bit muddled in the transition to print_function. I hope the attached patch applies easily so you can see what I'm talking about. |
daneah
approved these changes
Sep 29, 2016
Python 3 compatibility is implemented by removing `has_key` and using `__future__` for print function support. Also added ImageMagick as a requirement in README.md (since the `convert` command is part of ImageMagick).
|
@mzucker, I Applied the Patch. |
|
Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3 compatibility is implemented by removing
has_keyand using__future__for print function support. Also added ImageMagick as a requirement inREADME.md(since theconvertcommand is part of ImageMagick).