Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page config won't be used, if page config is changed in "GUI"/Normal mode #6

Open
0x01af opened this issue May 29, 2021 · 0 comments
Open

Comments

@0x01af
Copy link

0x01af commented May 29, 2021

Hi

If I change the config for Shortcode-Citation at page config by using the GUI/Normal mode (e.g. configure another text with "heading_text"), than this config haven't any effect.

The issue is based on saving the page config within section "shortcode-citation" (with dash) instead section "shortcode_citation" (with underscore). But, the TWIG template of Shortcode-Citation access the page config with an underscore.

There are two solutions:

  1. Change the fields definition in blueprints/default.yaml (from "shortcode-citation" to "shortcode_citation").
  2. Change the TWIG template templates/partials/citations.html.twig (line 4 from "{% set page_config = page.header.shortcode_citation %}" to "{% set page_config = page.header.shortcode-citation %}"

From my point of view, the first option seems the better one: Page configs/YAML uses often variables with "underscore" instead "dashes", because "dash" has another meaning in YAML too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant