Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to zmq-prebuilt 2.x #18

Merged
merged 2 commits into from Oct 7, 2016
Merged

Conversation

lgeiger
Copy link
Contributor

@lgeiger lgeiger commented Oct 7, 2016

We have prebuilt binaries working for Linux, OS X and Windows.
zmq-prebuilt can now be built from source as well to support rebuilding with different electron versions. In other words the fallback works 馃帀.

Copy link
Contributor

@rgbkrk rgbkrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃帀

@rgbkrk
Copy link
Contributor

rgbkrk commented Oct 7, 2016

Of note @n-riesco - @lgeiger has been propagating changes upstream to zeromq-node as well as bringing updates from zeromq.node into zmq-prebuilt. We will continue to follow SemVer.

@n-riesco
Copy link
Owner

n-riesco commented Oct 7, 2016

Tested on a 32b-linux machine and the fallback works!

@lgeiger Great work!

Is this or zmq-static ready for Hydrogen?

@n-riesco n-riesco merged commit d6ac425 into n-riesco:jmp-prebuilt Oct 7, 2016
@rgbkrk
Copy link
Contributor

rgbkrk commented Oct 7, 2016

Since I'm unfamiliar with your process - will this be posted with jmp-prebuilt?

@rgbkrk
Copy link
Contributor

rgbkrk commented Oct 7, 2016

zmq-static is now deprecated since zmq-prebuilt handles it.

Could we rely on zmq-prebuilt in jmp itself since this handles the fallback?

@n-riesco
Copy link
Owner

n-riesco commented Oct 7, 2016

@rgbkrk This PR's already published as jmp-prebuilt@0.5.1.

Is zmq-static deprecated because zmq-prebuilt builds the zmq library statically?
Does this mean that we don't need to ask users to install libzmq3-dev?

I'm also guessing from your question about jmp that the work in zmq-prebuilt won't be merged into zmq. Is that it?

@rgbkrk
Copy link
Contributor

rgbkrk commented Oct 7, 2016

Is zmq-static deprecated because zmq-prebuilt builds the zmq library statically?

Yes!

Does this mean that we don't need to ask users to install libzmq3-dev?

This is correct.

I'm also guessing from your question about jmp that the work in zmq-prebuilt won't be merged into zmq. Is that it?

We're going to try to, over time. Right now the process of getting things in, adjusting AppVeyor (and shipped assets), and anything involving settings on the zmq package is a bit of a pain. Within nteract, we have enough control to bring on collaborators with team level permissions and give them the freedom and responsibility to adjust things like AppVeyor + ship releases in automation.

@n-riesco
Copy link
Owner

n-riesco commented Oct 7, 2016

I feel a bit queasy about the idea of maintaining zmq-prebuilt outside the zmq community (we really need to get the changes in zmq-prebuilt merged into zmq).

I will release this PR as jmp@0.6.0 to help with testing zmq-prebuilt, but with the proviso that we intend to get zmq-prebuilt into zmq.

@lgeiger lgeiger deleted the jmp-prebuilt branch October 7, 2016 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants