Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should I put fastai_contrib subdir under ulmfit dir? #21

Closed
alexwwang opened this issue Dec 14, 2018 · 2 comments
Closed

Should I put fastai_contrib subdir under ulmfit dir? #21

alexwwang opened this issue Dec 14, 2018 · 2 comments

Comments

@alexwwang
Copy link

By default, it would report an error that "the fastai_contrib module is not found" when I execute postprocess_wikitext.py.

So I have to move it under ulmift dir and make it work properly.

I wonder, if this is a necessary step or do you meet this little slit?

@tpietruszka
Copy link
Contributor

I have stumbled upon the same problem. Another possible solution - calling from the main directory:

python -m ulmfit.postprocess_wikitext --path="data/wiki/wikitext-2" --lang="en"

I am currently trying to reproduce all the steps - starting with training on wikitext - writing down all the commands on the way.

Not sure what is the intended approach though.

@PiotrCzapla
Copy link
Member

The way @tpietruszka showed is what I'm using.
There are .sh scripts that should deal with this. But Guys there is a bug in postprocess_wikitext as it removes information about articles split in wikipedia which basically breaks the downstream tasks. So if you want to give it a try, try to fix the postprocess_wikitext.py so that it includes a way to split the wikipedia text by articles. see #25. This is an easy fix but I'm away Today so if you want to start training implement the fix. If you aren't in hurry just wait with your experiments until #25 is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants