Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

Don't race local against network immediately #29

Open
rklaehn opened this issue Dec 21, 2022 · 3 comments
Open

Don't race local against network immediately #29

rklaehn opened this issue Dec 21, 2022 · 3 comments

Comments

@rklaehn
Copy link
Contributor

rklaehn commented Dec 21, 2022

I think it would be better to give the local resolution a chance before firing off an expensive network operation.

Maybe have a small delay before the network operation to give local resolution a chance to complete, or only do the network resolution once the local resolution has failed.

@dignifiedquire
Copy link
Contributor

Where are you seeing this?

@rklaehn
Copy link
Contributor Author

rklaehn commented Dec 21, 2022

I saw lots of rpc calls opened and then immediately being cancelled/dropped in p2p when getting data that is present locally.

@dignifiedquire
Copy link
Contributor

we always first look at the store, so not sure where/what you are seeing there

@dignifiedquire dignifiedquire transferred this issue from n0-computer/iroh Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants