Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are chapters supported? #34

Closed
Crabtr opened this issue May 29, 2018 · 3 comments
Closed

Are chapters supported? #34

Crabtr opened this issue May 29, 2018 · 3 comments

Comments

@Crabtr
Copy link

Crabtr commented May 29, 2018

I'm currently working with some podcasts and I'm specifically trying to pull out their chapters. From what I can tell a CHAP (chapter) frame should be returned in an AllFrames() call, but only a TIT2 frame is being returned. Here's my code:

func main() {
	mp3, err := id3v2.Open(os.Args[1], id3v2.Options{Parse: true})
	if err != nil {
		panic(err)
	}
	defer mp3.Close()

	for key, frame := range mp3.AllFrames() {
		fmt.Println(key)
		fmt.Println(frame)
	}
}

Is this the correct method or does the library not support chapters? Also, here's the specific file I'm working with:

https://audio.fireside.fm/podcasts/audio/b/b44de5fa-47c1-4e94-bf9e-c72f8d1c8f5d/episodes/2/2bedf85e-f897-41e5-b498-243b1dea12b4/2bedf85e-f897-41e5-b498-243b1dea12b4.mp3

Edit: I think I should be looking for CHAP frames and not CTOC frames.

@n10v
Copy link
Owner

n10v commented Jun 3, 2018

Hi! Thank you for submitting this issue. The problem is that the second frame in the tag (COMM) has invalid size format: 11010000 on binary. It isn't allowed by specification (all sizes should always start with 0) and id3v2 can't parse these sizes correctly yet.

@n10v
Copy link
Owner

n10v commented Jun 3, 2018

Related to #13

@n10v
Copy link
Owner

n10v commented Aug 15, 2018

Fixed in 3845103

@n10v n10v closed this as completed Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants