Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Array access with invalid values return E_NOTICE since PHP 7.4 and may break queries #51

Closed
fdelapena opened this issue Dec 3, 2019 · 3 comments
Closed

Array access with invalid values return E_NOTICE since PHP 7.4 and may break queries #51

fdelapena opened this issue Dec 3, 2019 · 3 comments

Comments

@fdelapena
Copy link

I'm getting this with E_NOTICE enabled which breaks the query since PHP 7.4:

Notice: Trying to access array offset on value of type null in vendor/ozdemir/datatables/src/QueryBuilder.php on line 214

And this one twice for each column:

Notice: Trying to access array offset on value of type null in vendor/ozdemir/datatables/src/Column.php on line 101

Details on this tweet.
@n1crack
Copy link
Owner

n1crack commented Dec 3, 2019

Yeah, I’ll look into it tonight.

@n1crack
Copy link
Owner

n1crack commented Dec 3, 2019

refactored the code. It seems working now.

If you find any bugs, I would be appreciated if you tell me.

1427c04

@fdelapena
Copy link
Author

Updated from composer, it works flawless so far and the new code looks nice. Thank you for the fast update!

@n1crack n1crack closed this as completed Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fdelapena @n1crack