Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible typo in useRateLimiter example code #485

Closed
hitochan777 opened this issue Jul 25, 2021 · 1 comment · Fixed by #487
Closed

Possible typo in useRateLimiter example code #485

hitochan777 opened this issue Jul 25, 2021 · 1 comment · Fixed by #487
Labels
kind/docs Improvements or additions to documentation

Comments

@hitochan777
Copy link
Contributor

hitochan777 commented Jul 25, 2021 •
edited

Describe the bug

This is not a bug but a typo in a example code (I didn't know what template to use, sorry)

The example code for useRateLimiter imports wrong package name @envelop/generic-auth'.
Shouldn't it be @envelop/rate-limiter instead?
@n1ru4l
Copy link
Owner

n1ru4l commented Jul 25, 2021

@hitochan777 You wanna send a pr to fix this? 😊

@hitochan777 hitochan777 mentioned this issue Jul 25, 2021
Merged
8 tasks
@dotansimha dotansimha added the kind/docs Improvements or additions to documentation label Jul 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/docs Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes wrong package name in useRateLimiter example hitochan777/envelop
3 participants
@dotansimha @hitochan777 @n1ru4l