-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#7) Add fact that indicates if gpg is installed or not #8
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# Fact: gnupg_command | ||
# | ||
# Purpose: get full path to gpg exe | ||
# | ||
# Resolution: | ||
# Tests for presence of gpg, returns nil if not present | ||
# returns output of which gpg | ||
# | ||
# Caveats: | ||
# none | ||
# | ||
# Notes: | ||
# None | ||
Facter.add(:gnupg_command) do | ||
setcode do | ||
Facter::Util::Resolution.which('gpg') | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# Fact: gnupg_installed | ||
# | ||
# Purpose: determine if gpg exe exists on system | ||
# | ||
# Resolution: | ||
# Tests for presence of gpg, returns false if not present | ||
# returns true if which gpg finds an exe | ||
# | ||
# Caveats: | ||
# none | ||
# | ||
# Notes: | ||
# None | ||
Facter.add(:gnupg_installed) do | ||
setcode do | ||
!Facter.value(:gnupg_command).nil? | ||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you confirm that this function is available since Puppet 3.0.0 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Puppet 3.0.0 depends on Facter >= 1.6.11
https://rubygems.org/gems/puppet/versions/3.0.0
Facter::Util::Resolution.which
is present in Facter 1.6.11https://github.com/puppetlabs/facter/blob/1.6.11/lib/facter/util/resolution.rb#L36
I saw this code in the official puppetlabs java module, after trying a few other ideas.
https://github.com/puppetlabs/puppetlabs-java/blob/master/lib/facter/java_version.rb#L16
I assume it is compatible with all major versions of puppet supported by that module.