Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add year to date #14

Closed
dawsbot opened this issue Apr 4, 2017 · 1 comment
Closed

Add year to date #14

dawsbot opened this issue Apr 4, 2017 · 1 comment

Comments

@dawsbot
Copy link
Collaborator

dawsbot commented Apr 4, 2017

Date currently does not contain year. It's a challenge to determine which dates have already occurred without the year.

The best way to implement this might be to take s2016 and earlier as anomalies and have an object for them which provides the date. Something like this:

const knownYears = {
  s2016: 2016,
  f2016: 2016,
  s2015: 2015,
...
}

Then for na-2017 we can have a known dictionary of "<current year> - 1 months". Meaning that August - December in na-2017 are actually 2016 and then January onward are 2017.

Something like that. Let's go back and forth on ideas here before spending big time actually coding it to ensure there's a design we agree on.

@dawsbot
Copy link
Collaborator Author

dawsbot commented Apr 4, 2017

Just noticed it already has the date in our api. I was assuming it didn't strictly from looking at MLH's page. Woops!

@dawsbot dawsbot closed this as completed Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant