-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hackathons with an @ in their name return [email protected] #17
Comments
Thanks for the bug report @kristelfung! We'll have to take a look at this. Are you interested in taking a look at this? It would help us refine the documentation if we could see any missing or broken documentation on our end. |
Sure, I'll take a look! |
I suspect mlh.io is using Cloudflare's email address obfuscation, so anything with an @ is being treated as an email and is thus returning [email protected]. Maybe this will help! |
Sorry for the delay, I just sent the engineering team at MLH an email! Here's the solution they'd need to do: To prevent Cloudflare from obfuscating emails, you can: Add the following comment in the page HTML code: Updates to come! @kristelfung Thanks for publishing https://github.com/kristelfung/mlh-search you reminded me of this issue! Go tell people about this API and if it gets used more, MLH will be more likely to co-improve it when bugs like this come up :) |
@dawsbot Awesome, thanks for the update! I'll definitely spread the word about the API. |
"Thanks for sharing this with us. I know this isn't a long-term fix but you can retrieve the event name from the title attribute on the anchor tag. I cURL'd the events page and it doesn't seem like it obfuscates this attribute.
This holds up with Cloudflare's documentation that you shared so it's reasonably stable and would be a better solution than disabling email obfuscation on that page. Hope this helps and let me know you have any other issues." |
Looks like this is still an issue 😢 It's a Cloudfare setting that @MLH would need to adjust |
Looking at https://mlh-events.now.sh/na-2019, the hackathons HACK@WPI and HACK@CEWIT return [email protected] when trying to access their name.
The text was updated successfully, but these errors were encountered: