Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requirements #398

Closed
Sungray opened this issue Aug 5, 2023 · 3 comments
Closed

Requirements #398

Sungray opened this issue Aug 5, 2023 · 3 comments

Comments

@Sungray
Copy link

Sungray commented Aug 5, 2023

Currently, the "official" image cannot start, it's missing gtts in the requirements.

Also, the image cannot use plugins, as it requires additional requirements. That is unfortunate imho, and not in line with container philosophy, all requirements should be included in the base image by default.

Yes I can rebuild the image, but I would go the other way around: provide all required dependencies, and users who want to can remove them if they want a slimmer image.

@n3d1117
Copy link
Owner

n3d1117 commented Aug 5, 2023

Thanks for the feedback @Sungray, I don't use docker so I definitely didn't think of this.
So the only solution would be to include all the plugin requirements in the requirements.txt file, correct?

@Sungray
Copy link
Author

Sungray commented Aug 5, 2023

Thanks for the feedback @Sungray, I don't use docker so I definitely didn't think of this. So the only solution would be to include all the plugin requirements in the requirements.txt file, correct?

Yes, that is correct. Thank you!

@n3d1117 n3d1117 closed this as completed in 2c4b528 Aug 5, 2023
@n3d1117
Copy link
Owner

n3d1117 commented Aug 5, 2023

@Sungray latest docker image updated and should work out of the box with plugins now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants