Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build instructions missing #2

Closed
dvdmunckhof opened this issue Oct 4, 2022 · 2 comments
Closed

Build instructions missing #2

dvdmunckhof opened this issue Oct 4, 2022 · 2 comments

Comments

@dvdmunckhof
Copy link
Contributor

dvdmunckhof commented Oct 4, 2022 •
edited

Build steps and build dependencies seem to be missing from the package.json file. Could you provide build instructions?

I tried: (copied from https://github.com/n3r4zzurr0/react-range-slider-input/blob/master/package.json)

NODE_ENV=production babel src --out-dir dist --copy-files

However, the results did not match the contents of the npm package.

The reason I ask, is I wrote TypeScript type declarations that I'd like to contribute back to the project. By the way, awesome library! :)
@dvdmunckhof dvdmunckhof changed the title Build instructions Build instructions missing Oct 4, 2022
@n3r4zzurr0
Copy link
Owner

I have added the build instructions.
...
Sorry for the delay, I was heavily engaged in some other work.
Would love to have a contributor.

@dvdmunckhof
Copy link
Contributor Author

Thanks for adding the build instructions, it was very easy to build! I just created a pull request with my TypeScript type declarations 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dvdmunckhof @n3r4zzurr0