Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory usage improvements in EventTraceProperties #61

Open
daladim opened this issue Nov 3, 2022 · 0 comments
Open

Memory usage improvements in EventTraceProperties #61

daladim opened this issue Nov 3, 2022 · 0 comments

Comments

@daladim
Copy link
Collaborator

daladim commented Nov 3, 2022

Currently, we have

EventTraceProperties {
    etw_trace_properties,
    trace_name: [0; 1024],
    log_file_name: [0; 1024],
};

We could avoid using two arrays of 1024 bytes to store a string that's probably shorter than this. Maybe we could make EventTraceProperties generic on the name length, or really support dynamic allocation of the name
@daladim daladim changed the title Memory use: avoid allocating 2*104 bytes for trace name and log file name Memory usage: avoid allocating 2*104 bytes for trace name and log file name Nov 3, 2022
@daladim daladim changed the title Memory usage: avoid allocating 2*104 bytes for trace name and log file name Memory usage improvements in EventTraceProperties Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@daladim