storage.uploadFile does not return UploadTask

[eugenio1590]

I am calling the 'storage.uploadFile' function and I get an error when trying to subscribe to the event channel. This is because the function returns an 'UploadTaskSnapshot' object. This is my code:

const task = yield call(reduxSagaFirebase.storage.uploadFile, file.serverPath, file)
console.log(task)
const channel = eventChannel(emit => task.on('state_changed', emit))
yield takeEvery(channel, function* callback(snapshot) {
  console.log(snapshot)
})
yield task

The image is saved in Firebase but I am going to display the progress bar with the information of the snapshot but in the task.

"firebase": "^5.9.1",
"redux-saga-firebase": "^0.15.0",

[eugenio1590]

I resolved it calling the function directly and wait for the task to finish at the bottom.

const task = reduxSagaFirebase.storage.uploadFile(file.serverPath, file)
const channel = eventChannel(emit => task.on('state_changed', emit))
yield takeEvery(channel, function* callback(snapshot) {
  console.log(snapshot)
})
yield task

It's important to update the documentation.

[n6g7]

Hi there,

Thanks for the feedback!

Unfortunately that's a side effect of firebase.storage.UploadTask having a then method, so redux-saga assumes it's a promise and resolves it.

So, as far as I can tell, your solution is correct, even though you lose the ability to properly test your saga. That's actually exactly what I did in the example codebase to go around this issue.

I'll update the docs, thanks!

[eugenio1590]

Yes, the test is difficult to with this change. But using a manual mock with jest for returning the correct answer, It worked for me. Thanks to you.