Get Bridge Dialog Improvements #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Intent generated to handle the email request would actually just open up any application that supported the MIME type
type/rfc822instead of just mail clients. On my device a bunch of other apps were available for me including Signal and a System Bluetooth app.Launching the email Intent before this PR:
Launching the email Intent with the changes introduced in this PR:
Additionally, the
AlertDialogfor this feature uses a custom layout that is not needed. By removing the custom dialog layout from the project the dialog looks prettier (and more line with Material Design guidelines) and we have less xml hanging out in our codebase.Dialog Before PR:
After PR:
Finally, I formatted some code and touched up some of the UI Strings in an effort to have a cleaner codebase and UX.