Win console fix #124
Merged
Win console fix #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed an explicit Console.flush(). This makes the Windows console work correctly.
|
Did you also test the changes with a unix-y console? |
|
Yeah, just now. :) It works great on my LinuxMint laptop. |
|
Have you published yet? I'm not able to resolve 0.6.1. Let me know, and I'll double check the published one on Windows. |
|
No, this isn't published yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated so the prompts appear at the appropriate time on Windows. I moved the message part of
Console.readLineto a separate call toprintf()followed by an explicitConsole.flush(). Per the scaladoc forConsole.flush():Since
Console.readLine()doesn't print a newline, it needs a call toflush(). I suspect this is ultimately a workaround for a bug inConsole.This corrects issue #114 and potentially #98.