Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update RundeckApi Credential #3879

Merged
merged 6 commits into from
Oct 16, 2022
Merged

update RundeckApi Credential #3879

merged 6 commits into from
Oct 16, 2022

Conversation

AndLLA
Copy link
Contributor

@AndLLA AndLLA commented Aug 12, 2022

this fix updates RunDeck Credential in order to support:

  • testing
  • integration with the HTTP Request "Predefined Credential Type" mechanism

@CLAassistant
Copy link

CLAassistant commented Aug 12, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request labels Aug 12, 2022
@janober
Copy link
Member

janober commented Aug 12, 2022

Great, thanks a lot! Could you please also change that the node uses:
this.helpers.requestWithAuthentication.call(this, credentialType, options)
instead of
await this.executeFunctions.helpers.request!(options) here and remove the headers. That makes sure that the node actually uses the authentication logic defined in the credentials instead of using its own logic. Else it could result in the test working fine but the node actually failing (as they do different things).

You can find an example here.

Thanks a lot!

@AndLLA
Copy link
Contributor Author

AndLLA commented Aug 12, 2022 •
edited

hallo,
I added the requested fix,
hope I got it right :) (testing was ok)

Thanks !!!

@janober
Copy link
Member

janober commented Aug 12, 2022

Thanks a lot. From a short look does it look correct. We will then do a proper review and merge soon. Have a great weekend!

@AndLLA
Copy link
Contributor Author

AndLLA commented Aug 30, 2022

Hi,
I updated the pull request, resolving a small conflict vs to the trunk.

@janober janober merged commit fc87650 into n8n-io:master Oct 16, 2022
@janober
Copy link
Member

janober commented Oct 16, 2022

Thanks a lot for your contribution @AndLLA. Got merged and will be released with the next version.

@janober janober added the Upcoming Release Will be part of the upcoming release label Oct 16, 2022
@janober
Copy link
Member

janober commented Oct 21, 2022

Got released with n8n@0.199.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Oct 21, 2022
@AndLLA AndLLA deleted the rundeckapi-creds branch October 21, 2022 12:03
valya pushed a commit to valya/n8n that referenced this pull request Nov 8, 2022
@AndLLA
feat(Rundeck Node): Update credential with test and make useable in H…
e4084a4 
…TTP Request node (n8n-io#3879)

* add support for authenticate, test to RundeckApi Credentials

* ensure that the RunDeckApi note uses the authentication mechanism
defined incredentials
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
community Authored by a community member node/improvement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AndLLA @CLAassistant @janober