fix(public-api): Fix error updating workflow with property not defined in the schema #4089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
mieky
force-pushed
the
n8n-4595-public-api-crashes-when-updating-workflow
branch
from
4bc1e39
to
bfa8165
Compare
RicardoE105
changed the title
RicardoE105
approved these changes
Sep 14, 2022
RicardoE105
deleted the
n8n-4595-public-api-crashes-when-updating-workflow
branch
n8n-assistant
bot
added
the
Upcoming Release
|
Got released with |
valya
pushed a commit
to valya/n8n
that referenced
this pull request
Nov 8, 2022
…d in the schema (n8n-io#4089) * fix(cli): catch errors on updating workflow * ⚡ Don\'t allow additionalProperties in the workflow schema Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an interim fix before we have schema validation in place, this should fix any unexpected API crashes trying to update a workflow with malformed contents, and return a HTTP 400 instead. Workflow creation isn't affected.
More details on the Linear issue.