perf: update deepCopy #4364
Merged
perf: update deepCopy #4364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
|
Thumbs up for the effort, love to see you take this on! 💯 The implementation seems very quick indeed. I would perhaps consider sticking with lodash's cloneDeep if only for the maintainability, and the fact we're using lodash in many places already. Importing it from within |
|
@mieky in frontend we actually want to get rid of |
mutdmour
previously approved these changes
Oct 18, 2022
mutdmour
approved these changes
Oct 18, 2022
n8n-assistant
bot
added
the
Upcoming Release
|
Got released with |
valya
pushed a commit
to valya/n8n
that referenced
this pull request
Nov 8, 2022
* perf: update deepCopy * fix: using deepCopy in core and cli packages * fix: using deepCopy in editor * chore: formatting * fix: some micro optimisation in deepCopy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON.parse(JSON.stringify(object))has a very low performancecheck the benchmarks here:
http://jsben.ch/WRTkU