Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Redirect users to canvas if they don't have any workflows #5629

Merged
merged 7 commits into from
Mar 8, 2023

Conversation

OlegIvaniv
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Mar 6, 2023
@MiloradFilipovic MiloradFilipovic self-requested a review March 7, 2023 14:35
Copy link
Contributor

@MiloradFilipovic MiloradFilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, I just have one question: Is there a point having workflows link in the sidebar when users have no workflows?
Screen Recording 2023-03-07 at 15 32 13

@OlegIvaniv
Copy link
Contributor Author

OlegIvaniv commented Mar 7, 2023

Code looks good, I just have one question: Is there a point having workflows link in the sidebar when users have no workflows? Screen Recording 2023-03-07 at 15 32 13

I think so, otherwise, there would be no way to get to the canvas if the user would be for example in the settings

@OlegIvaniv OlegIvaniv merged commit 354edf6 into master Mar 8, 2023
@OlegIvaniv OlegIvaniv deleted the ado-290-feature-bring-new-users-to-empty-canvas branch March 8, 2023 14:11
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Mar 8, 2023
MiloradFilipovic added a commit that referenced this pull request Mar 10, 2023
* master: (358 commits)
  refactor: Remove n8n-core dependency in nodes-base (no-changelog) (#5649)
  🚀 Release 0.219.0 (#5659)
  fix(core): Fix trying to pipe a non stream on errors (no-changelog) (#5660)
  ci: Fix e2e tests (no-changelog) (#5658)
  fix(core): Fix issues with LDAP reset and LDAP init (no-changelog) (#5657)
  feat(HTTP Request Node): Move from Binary Buffer to Binary streaming (#5610)
  feat(editor): Only redirect new users to blank canvas (no-changelog) (#5654)
  feat(editor): Do not automatically add manual trigger on node plus (#5644)
  feat(core): Allow using middlewares with decorators on a per-route basis (no-changelog) (#5656)
  refactor(core): Convert more routes to use the decorator pattern (no-changelog) (#5611)
  fix: Fetch credentials on workflows view to include in duplicated workflows (#5532)
  ci: Add PR checklist (#5628)
  feat(Mindee Node): Add support for v4 API (#5559)
  feat(Microsoft SQL Node): Add support for self signed certificates (#5160)
  fix(editor): Only fetch new versions at app launch (#5647)
  fix(core): Use new version of riot-tmpl in workflow package (no-changelog) (#5619)
  feat(core): Refactor and add SAML preferences for service provider instance (#5637)
  docs(Github Trigger Node): Add notice and more meaningful error around permissions (#5551)
  feat(Cal Trigger Node): Update to support v2 webhooks (#5331)
  feat(editor): Redirect users to canvas if they don't have any workflows (#5629)
  ...
@janober
Copy link
Member

janober commented Mar 10, 2023

Got released with n8n@0.219.1

@janober janober removed the Upcoming Release Will be part of the upcoming release label Mar 10, 2023
sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
…ws (n8n-io#5629)

* feat(editor): Bring new users to empty canvas

* Fix failing e2e tests and revert CLI implementation

* Revert editor-ui Interface changes

* Try to mock /settings and /active

* Revert canvas test changes, reload after executions in 20-workflow-executions

* Make sure we include manual executiosn before running them in 20-workflow-executions

* Make sure to re-init node view when replacing empty workflows route, show phantom loader
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants