Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix owner set-up checkbox wording #5697

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

romainminaud
Copy link
Contributor

Change the wording of the checkbox on the Set-up Account owner page from "I’d be OK sharing my opinion on n8n (no marketing emails though)" to "Inform me about security vulnerabilities if they arise"

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Make sure to check off this list before asking for review.

@romainminaud romainminaud marked this pull request as ready for review March 15, 2023 13:34
@romainminaud romainminaud changed the title update checkbox wording fix(editor): Fix owner set-up checkbox wording Mar 15, 2023
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (b4e60c3) 13.03% compared to head (12d92e9) 13.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5697      +/-   ##
==========================================
- Coverage   13.03%   13.03%   -0.01%     
==========================================
  Files        2454     2454              
  Lines      112597   112597              
  Branches    17486    17490       +4     
==========================================
- Hits        14682    14679       -3     
- Misses      97415    97418       +3     
  Partials      500      500              

see 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Mar 15, 2023
@romainminaud romainminaud merged commit 58232be into master Mar 16, 2023
@romainminaud romainminaud deleted the pay-255-change-checkbox-label-on-owner-set-up branch March 16, 2023 08:58
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Mar 16, 2023
@janober
Copy link
Member

janober commented Mar 16, 2023

Got released with n8n@0.220.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Mar 16, 2023
sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants