Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Add secondary icon to menu items #6351

Conversation

cstuncsik
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Files matching packages/design-system/**/*.vue:

  • Used design system tokens (colors, spacings...) where possible.
  • Updated Storybook with new component or updated functionality.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jun 1, 2023
@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Patch coverage: 8.69% and no project coverage change.

Comparison is base (1b32141) 28.31% compared to head (891bada) 28.32%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6351   +/-   ##
=======================================
  Coverage   28.31%   28.32%           
=======================================
  Files        2982     2982           
  Lines      185129   185148   +19     
  Branches    20295    20297    +2     
=======================================
+ Hits        52425    52445   +20     
+ Misses     131919   131918    -1     
  Partials      785      785           
Impacted Files Coverage Δ
...ign-system/src/components/N8nMenuItem/MenuItem.vue 0.00% <0.00%> (ø)
packages/design-system/src/types/menu.ts 0.00% <0.00%> (ø)
packages/editor-ui/src/components/MainSidebar.vue 43.96% <0.00%> (-0.22%) ⬇️
packages/editor-ui/src/plugins/icons/index.ts 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cstuncsik cstuncsik requested a review from alexgrozav June 1, 2023 13:44
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

✅ All Cypress E2E specs passed

@cstuncsik cstuncsik requested a review from alexgrozav June 1, 2023 14:54
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

✅ All Cypress E2E specs passed

@cstuncsik cstuncsik merged commit 3dd2601 into master Jun 2, 2023
24 checks passed
@cstuncsik cstuncsik deleted the pay-480-add-a-lock-icon-on-workflow-menu-item-when-instance-is-in branch June 2, 2023 10:00
MiloradFilipovic added a commit that referenced this pull request Jun 2, 2023
* master:
  fix(editor): Fix hard-coded parameter names for code editors (#6372)
  ci: Add support for Node.js 18 (#5793)
  ci: Update the release process for v1 release (#6366)
  refactor: Add deprecation notice for UM disabled mode (#6367)
  feat(editor): Make WF name a link on /executions (#6354)
  ci: Revert "Set up Turborepo cache for GitHub actions runner" (#6364) (no-changelog)
  fix(editor): Add secondary icon to menu items (#6351)
  fix(editor): Pin all data regardless of pagination (#6346)
  feat(Crypto Node): Add support for hash and hmac on binary data (#6359)
  ci: Set up Turborepo cache for GitHub actions runner (no-changelog) (#6335)

# Conflicts:
#	packages/editor-ui/src/components/ParameterInput.vue
@janober
Copy link
Member

janober commented Jun 14, 2023

Got released with n8n@0.232.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants