Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Linear Node): Fix issue creation priority #6813

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (7832e9c) 24.61% compared to head (2918bef) 24.61%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6813      +/-   ##
==========================================
- Coverage   24.61%   24.61%   -0.01%     
==========================================
  Files        3122     3122              
  Lines      190561   190561              
  Branches    20946    20944       -2     
==========================================
- Hits        46916    46914       -2     
- Misses     142715   142717       +2     
  Partials      930      930              
Files Changed Coverage Δ
...ckages/nodes-base/nodes/Linear/IssueDescription.ts 0.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress
Copy link

cypress bot commented Aug 1, 2023

1 flaky tests on run #1700 ↗︎

0 221 0 0 Flakiness 1

Details:

🌳 fix-linear-issue-creation-priority 🖥️ browsers:node18.12.0-chrome107 🤖 ivov...
Project: n8n Commit: 2918bef402
Status: Passed Duration: 57:36 💡
Started: Aug 1, 2023 8:00 AM Ended: Aug 1, 2023 8:57 AM
Flakiness  cypress/e2e/11-inline-expression-editor.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Inline expression editor > should resolve $parameter[] Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/improvement New feature or request labels Aug 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

✅ All Cypress E2E specs passed

@ivov ivov merged commit fce8cc4 into master Aug 1, 2023
48 of 49 checks passed
@ivov ivov deleted the fix-linear-issue-creation-priority branch August 1, 2023 08:58
@github-actions github-actions bot mentioned this pull request Aug 9, 2023
@janober
Copy link
Member

janober commented Aug 9, 2023

Got released with n8n@1.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants