Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement MistralCloud Chat & Embeddings nodes #8239

Merged
merged 4 commits into from
Jan 8, 2024
Merged

feat: Implement MistralCloud Chat & Embeddings nodes #8239

merged 4 commits into from
Jan 8, 2024

Conversation

OlegIvaniv
Copy link
Contributor

@OlegIvaniv OlegIvaniv commented Jan 5, 2024 •
edited

Summary

  • Add Mistral Cloud API credential
  • Add Mistral Embeddings node
  • Add Mistral Cloud Chat node
  • Add pnpm override for @langchain/core package

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.

@OlegIvaniv
feat(LmChatMistralCloud Node): Implement MistralCloud Chat & Embeddin…
81841aa 
…gs nodes

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv OlegIvaniv force-pushed the n8n-7144-mistral-cloud-lm-embeddings branch from b1b93e9 to 81841aa Compare January 5, 2024 11:15
@OlegIvaniv OlegIvaniv changed the title feat(LmChatMistralCloud Node): Implement MistralCloud Chat & Embeddings nodes feat: Implement MistralCloud Chat & Embeddings nodes Jan 5, 2024
@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Jan 5, 2024
michael-radency
michael-radency approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@michael-radency michael-radency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , updated svg icon to be more readable

@cypress Cypress
Copy link

cypress bot commented Jan 8, 2024

1 flaky test on run #3650 ↗︎

0 330 5 0 Flakiness 1

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 OlegIvaniv 🗃️ e2e/*
Project: n8n Commit: d78c49f486
Status: Passed Duration: 07:02 💡
Started: Jan 8, 2024 2:53 PM Ended: Jan 8, 2024 3:00 PM
Flakiness  cypress/e2e/29-templates.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Templates > should save template id with the workflow Screenshots Video

Review all test suite changes for PR #8239 ↗︎

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2024

✅ All Cypress E2E specs passed

@OlegIvaniv OlegIvaniv merged commit d37b908 into master Jan 8, 2024
19 checks passed
@OlegIvaniv OlegIvaniv deleted the n8n-7144-mistral-cloud-lm-embeddings branch January 8, 2024 15:17
@github-actions github-actions bot mentioned this pull request Jan 10, 2024
Merged
@LucBerge
Copy link

LucBerge commented Jan 16, 2024 •
edited

Hello @michael-radency and @OlegIvaniv ,
first of all thank you for your job, MistralAI is what I was looking for.
You worked on the MistralAI implementation so you might have the answer to this question:
Do you know why is the "MistralAI model" not compatible with the "AI Agent" node?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-radency michael-radency michael-radency approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@OlegIvaniv @LucBerge @michael-radency