fix(core): Errors are returned on the success branch if error item has other keys in addition to 'error' #8380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-radency
added
core
elsmr
approved these changes
Jan 18, 2024
Passing run #3816 ↗︎
Details:
Review all test suite changes for PR #8380 ↗︎ |
|||||||||||||||
|
✅ All Cypress E2E specs passed |
michael-radency
deleted the
node-1032-mysql-errors-are-returned-on-the-success-branch
branch
ivov
pushed a commit
that referenced
this pull request
Jan 22, 2024
…s other keys in addition to 'error' (#8380)
Merged
|
Got released with |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Errors are returned on the success branch if error item has other keys in addition to 'error'
Related tickets and issues
https://community.n8n.io/t/mysql-error-shows-as-success/34589
https://linear.app/n8n/issue/NODE-1032/errors-are-returned-on-the-success-branch-if-error-item-has-other-keys