-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(editor): Add sections to autocomplete dropdown #8720
feat(editor): Add sections to autocomplete dropdown #8720
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful 😍 Left a really minor comment but otherwise good to go
packages/editor-ui/src/plugins/codemirror/resolvableHighlighter.ts
Outdated
Show resolved
Hide resolved
|
2 flaky tests on run #4318 ↗︎
Details:
5-ndv.cy.ts • 1 flaky test
19-execution.cy.ts • 1 flaky test
Review all test suite changes for PR #8720 ↗︎ |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing 🙌
✅ All Cypress E2E specs passed |
Got released with |
Co-authored-by: Giulio Andreini <andreini@netseven.it>
Summary
<object>.keys()
and<object>.values()
actually work.values(<cursor>)
instead of.values()<cursor>
Related tickets and issues
https://linear.app/n8n/issue/NODE-1147/introduce-autocomplete-inner-sections
Review / Merge checklist
(no-changelog)
otherwise. (conventions)