Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Chat Trigger exclude summarization node from valid ai nodes #8875

Conversation

michael-radency
Copy link
Contributor

Summary

  • Summarization node would not be considered as valid ai node for chat and error message would be shown if no other ai nodes present
  • updated error description

Related tickets and issues

https://linear.app/n8n/issue/AI-135/chat-trigger-fail-execution-if-no-compatible-root-nodes-eg-if-only

#8393

@michael-radency michael-radency added n8n team Authored by the n8n team node/issue Issue with a node labels Mar 13, 2024
OlegIvaniv
OlegIvaniv previously approved these changes Mar 13, 2024
Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Mar 13, 2024

1 flaky test on run #4377 ↗︎

0 343 12 0 Flakiness 1

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Project: n8n Commit: dc4b3ae343
Status: Passed Duration: 03:45 💡
Started: Mar 14, 2024 7:24 AM Ended: Mar 14, 2024 7:28 AM
Flakiness  cypress/e2e/5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Test Replay Screenshots Video

Review all test suite changes for PR #8875 ↗︎

…at-trigger-fail-execution-if-no-compatible-root-nodes-eg
Copy link
Contributor

✅ All Cypress E2E specs passed

@michael-radency michael-radency merged commit 4861556 into master Mar 14, 2024
28 checks passed
@michael-radency michael-radency deleted the ai-135-chat-trigger-fail-execution-if-no-compatible-root-nodes-eg branch March 14, 2024 07:43
@github-actions github-actions bot mentioned this pull request Mar 20, 2024
@janober
Copy link
Member

janober commented Mar 20, 2024

Got released with n8n@1.34.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/issue Issue with a node Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants