fix(editor): Fix an issue with an empty chat response if not in output property
#8913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut` property Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
alexgrozav
approved these changes
Mar 18, 2024
|
✅ All Cypress E2E specs passed |
3 flaky tests on run #4405 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Test Replay
Screenshots
Video
|
|
17-sharing.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Sharing > should work for admin role on credentials created by others (also can share it with themselves) |
Test Replay
Screenshots
Video
|
|
24-ndv-paired-item.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #8913 ↗︎
OlegIvaniv
deleted the
ai-156-chat-node-hosted-form-responses-are-broken
branch
3 tasks
Merged
|
Got released with |
This was referenced Mar 27, 2024
Closed
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where the chat message would render as
<Empty response>when using basic or QA chains.When rendering the chat message,
@n8n/chatlooks for it in theoutputproperty of the response object. This is how we return it for agents but not for chains. So we add thetextproperty fallback, and if none of them are defined, try to render a full stringified response.