Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(editor): Show tip when user can type dot after an expression #8931

Merged
merged 11 commits into from
Mar 26, 2024
Merged

feat(editor): Show tip when user can type dot after an expression #8931

merged 11 commits into from
Mar 26, 2024

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Mar 20, 2024

Summary

Help users discover they can type . to see all methods/fields

image

Related tickets and issues

https://linear.app/n8n/issue/NODE-1251/help-users-discover-they-can-type-to-see-all-methodsfields

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Mar 20, 2024
ivov
ivov reviewed Mar 22, 2024
View reviewed changes
Copy link
Contributor

@ivov ivov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

packages/editor-ui/src/components/InlineExpressionEditor/InlineExpressionTip.vue Outdated Show resolved Hide resolved
packages/editor-ui/src/components/InlineExpressionEditor/__tests__/InlineExpressionTip.test.ts Show resolved Hide resolved
packages/editor-ui/src/composables/useExpressionEditor.ts Show resolved Hide resolved
packages/editor-ui/src/plugins/codemirror/completions/utils.ts Outdated Show resolved Hide resolved
packages/editor-ui/src/plugins/i18n/locales/en.json Outdated Show resolved Hide resolved
packages/editor-ui/src/components/InlineExpressionEditor/InlineExpressionTip.vue Outdated Show resolved Hide resolved
packages/editor-ui/src/components/InlineExpressionEditor/InlineExpressionTip.vue Show resolved Hide resolved
packages/editor-ui/src/components/ExpressionParameterInput.vue Outdated Show resolved Hide resolved
@elsmr elsmr requested a review from ivov March 26, 2024 08:58
ivov
ivov previously approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@ivov ivov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing everything, beautiful work! Learned quite a bit from your implementation as well.

@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress Cypress
Copy link

cypress bot commented Mar 26, 2024 •
edited

Passing run #4467 ↗︎

0 343 12 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Project: n8n Commit: 77c38b8899
Status: Passed Duration: 03:42 💡
Started: Mar 26, 2024 2:12 PM Ended: Mar 26, 2024 2:16 PM

Review all test suite changes for PR #8931 ↗︎

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@elsmr elsmr merged commit 160dfd3 into master Mar 26, 2024
48 of 50 checks passed
@elsmr elsmr deleted the node-1251-help-users-discover-they-can-type-to-see-all-methodsfields branch March 26, 2024 14:23
This was referenced Mar 27, 2024
Closed
Merged
@janober
Copy link
Member

janober commented Mar 27, 2024

Got released with n8n@1.35.0

@github-actions github-actions bot mentioned this pull request Apr 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivov ivov ivov approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@elsmr @janober @ivov