Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Anthropic Chat Model Node): Fix detection of chat models in docker build & add support Claude Haiku #8953

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

OlegIvaniv
Copy link
Contributor

@OlegIvaniv OlegIvaniv commented Mar 22, 2024

Summary

  • Fix the detection of Chat Models in Docker container by using lc_namespace instead of relying on the base class
  • Add Claude Haiku model

Related tickets and issues

Include links to Linear ticket or Github issue or Community forum post. Important in order to close automatically and provide context to reviewers.

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

…r build & add support Claude Haiku

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Mar 22, 2024
Copy link
Contributor

@michael-radency michael-radency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Mar 22, 2024

3 flaky tests on run #4445 ↗︎

0 343 12 0 Flakiness 3

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 OlegIvaniv 🗃️ e2e/*
Project: n8n Commit: c58ec46a67
Status: Passed Duration: 03:46 💡
Started: Mar 22, 2024 10:22 AM Ended: Mar 22, 2024 10:25 AM
Flakiness  5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Test Replay Screenshots Video
Flakiness  19-execution.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Execution > should test manual workflow stop Test Replay Screenshots Video
Flakiness  24-ndv-paired-item.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > resolves expression with default item when input node is not parent, while still pairing items Test Replay Screenshots Video

Review all test suite changes for PR #8953 ↗︎

@OlegIvaniv OlegIvaniv merged commit 76041b8 into master Mar 22, 2024
28 checks passed
@OlegIvaniv OlegIvaniv deleted the ai_chat_models_detection branch March 22, 2024 11:03
krynble pushed a commit that referenced this pull request Mar 25, 2024
…r build & add support Claude Haiku (#8953)

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
@github-actions github-actions bot mentioned this pull request Mar 25, 2024
@janober
Copy link
Member

janober commented Mar 25, 2024

Got released with n8n@1.34.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants