fix(core): Stringify all Luxon DateTimes in cleanupParameterData #8959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsmr
changed the title
n8n-assistant
bot
added
core
krynble
approved these changes
Mar 25, 2024
1 flaky test on run #4451 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #8959 ↗︎
|
✅ All Cypress E2E specs passed |
|
Got released with |
This was referenced Mar 27, 2024
Closed
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After #8910,
cleanupParameterDatadoesn't stringify all DateTime objects.The bug in this Linear ticket is caused by the DateTime object not being converted to a string, and later on in the Set node being
JSON.stringify-ed (causing it to be surrounded with"")Related tickets and issues
https://linear.app/n8n/issue/N8N-7278/datetimes-are-given-extra-when-stringified
Review / Merge checklist
(no-changelog)otherwise. (conventions)