Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix accidental IDE code addition #8971

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

cstuncsik
Copy link
Contributor

No description provided.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Mar 26, 2024
Copy link

cypress bot commented Mar 26, 2024

2 flaky tests on run #4460 ↗︎

0 343 12 0 Flakiness 2

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 cstuncsik 🗃️ e2e/*
Project: n8n Commit: 60b42290ab
Status: Passed Duration: 03:53 💡
Started: Mar 26, 2024 9:34 AM Ended: Mar 26, 2024 9:38 AM
Flakiness  5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Test Replay Screenshots Video
Flakiness  17-sharing.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Sharing > should work for admin role on credentials created by others (also can share it with themselves) Test Replay Screenshots Video

Review all test suite changes for PR #8971 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@cstuncsik cstuncsik merged commit 117b57c into master Mar 26, 2024
30 of 33 checks passed
@cstuncsik cstuncsik deleted the fix-accidental-ide-code-addition branch March 26, 2024 09:50
This was referenced Mar 27, 2024
@janober
Copy link
Member

janober commented Mar 27, 2024

Got released with n8n@1.35.0

@github-actions github-actions bot mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants